Repository navigation
Add foreground generation screen dimming - #774
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in Dim screen toggle as the first App settings option. Foreground generation keeps the display awake and can lower brightness to 1%; minimizing restores the previous display settings, and returning reapplies dimming while generation is still running. Completion and cancellation restore the display settings.
Touching the screen temporarily restores normal brightness, then dimming resumes after 1,750 ms of inactivity. Each touch restarts the timer, including touches on the progress card and the surrounding area; Cancel remains usable.
Dimming is active only with background generation off. The option remains visible and configurable with background generation on, with an asterisk and an explanatory hint. Includes six-language localization and backup support.
Addresses #175.
Checklist
Tested On
Validated foreground start, minimize/resume, completion, and disabled dimming through the built-in A1111 demo flow. Verified iOS brightness setter arguments with the debugger; physical iPhone brightness remains unverified. The background-generation asterisk/hint was checked in the iOS app. Android/iOS compilation, Kotlin lint, presentation architecture checks, and Android Studio formatting pass. The touch/timer, repeated-touch, progress-dialog, minimize/resume, completion and cancellation flows were verified in the iOS simulator using actual UIKit brightness setter calls. The new touch interaction was not rerun on Android. No automated tests were added.