Skip to content

Add prompt clear buttons and gate native MNN checks by changes - #771

Merged
ShiftHackZ merged 2 commits into
developfrom
feature/clear-prompt
Nov 19, 2026
Merged

ShiftHackZ merged 2 commits into
developfrom
feature/clear-prompt

Conversation

@ShiftHackZ

@ShiftHackZ ShiftHackZ commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Adds clear buttons to positive and negative prompt fields in tagged and normal modes on Android and iOS. Clearing removes all tags and pending text for that field while preserving the other prompt. Typed text also follows the dark theme.

The expensive Linux/Apple MNN jobs now run only for MNN-related changes. Detection covers the full PR branch diff or the complete pushed range on develop/master, including earlier commits. MNN integration references and build inputs trigger checks; edits to the detector itself do not. Other CI checks continue to run.

Addresses the clear-button request in #294. LLM prompt building and custom GGUF models are out of scope.

Validation: Android fullDev and iOS simulator builds, Kotlin lint, presentation architecture, and Android Studio formatting checks passed. Verified tagged/normal prompt clearing, independent fields, and dark-theme text in the real Android and iOS apps. Workflow Actionlint, shell syntax, Prettier, and local selector checks against real repository history passed. Live CI run 44478586473 passed change detection and skipped the entire MNN matrix; neither native platform job started. Other CI checks are still running.

@ShiftHackZ ShiftHackZ linked an issue Nov 19, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../generation/widget/input/GenerationPromptEditor.kt 0.00% 15 Missing ⚠️
...tion/components/widget/input/chip/ChipTextField.kt 0.00% 4 Missing ⚠️
...ponents/widget/input/chip/ChipTextFieldWithItem.kt 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ShiftHackZ ShiftHackZ changed the title Add clear buttons to tagged and normal prompt inputs Add prompt clear buttons and gate native MNN checks by changes Nov 19, 2026
@ShiftHackZ
ShiftHackZ merged commit 93975c7 into develop Nov 19, 2026
9 checks passed
@ShiftHackZ
ShiftHackZ deleted the feature/clear-prompt branch November 19, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear prompt button

1 participant