Repository navigation
Add prompt clear buttons and gate native MNN checks by changes - #771
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clear buttons to positive and negative prompt fields in tagged and normal modes on Android and iOS. Clearing removes all tags and pending text for that field while preserving the other prompt. Typed text also follows the dark theme.
The expensive Linux/Apple MNN jobs now run only for MNN-related changes. Detection covers the full PR branch diff or the complete pushed range on develop/master, including earlier commits. MNN integration references and build inputs trigger checks; edits to the detector itself do not. Other CI checks continue to run.
Addresses the clear-button request in #294. LLM prompt building and custom GGUF models are out of scope.
Validation: Android fullDev and iOS simulator builds, Kotlin lint, presentation architecture, and Android Studio formatting checks passed. Verified tagged/normal prompt clearing, independent fields, and dark-theme text in the real Android and iOS apps. Workflow Actionlint, shell syntax, Prettier, and local selector checks against real repository history passed. Live CI run 44478586473 passed change detection and skipped the entire MNN matrix; neither native platform job started. Other CI checks are still running.