ci: trigger publish/release on version tags only - #43
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
shiftcontrol-dan
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.ymlandrelease.ymlboth triggered onpushtomainand onv*.*.*tags. During the 0.4.1 release that meantcargo publishran twice: the merge tomainpublished, then the tag run failed witherror: crate scim_v2@0.4.1 already exists on crates.io index. Publishing on amainpush is also wrong in principle — any non-release commit tomainattempted a publish.Both workflows now trigger on tags only, so the release is driven solely by pushing
v<version>:release.yml'sif: startsWith(github.ref, 'refs/tags/v')guard is dropped since it's now redundant.Added a guard in
publish.ymlthat fails fast if the tag doesn't matchCargo.toml, so a mistyped tag can't publish the wrong version:Release process after this: merge the version bump, then push the
v<version>tag.Link to Devin session: https://app.devin.ai/sessions/15892de8aceb410ab92791f60c1d8d7e
Requested by: @shiftcontrol-dan