Docs: the audit, the coverage, and the real-data checks behind them - #34
Merged
Merged
Conversation
README and site: J1939 now 26 PGNs and 152 parameters by the J1939-71 layouts, with the audit that found the old table's wrong bytes and wrong messages and the truck-log cross-checks that confirm the new one; NMEA 2000 now every standard PGN canboat defines (216); OBD-II 78 PIDs, modes 03 and 07 for DTCs, silence reported as silence; ISO-TP tested against can-isotp and the STmin defect that found; openpilot logs open with the bundled schema; the calibrator checked on two real cars from comma.ai. Counts from the runs: 753 unit tests, 99 real-data checks in the two corpora, 33 in the stress run. Limitations updated honestly: one physical adapter has now been used (a CANalyst-II on a Tata Tigor EV, 111,006 frames); UDS, ISO-TP, security access and OBD-II are tested against scripted responders and independent implementations, not a real ECU; J1939 coverage is 26 groups. Removed a false claim: the site's install page and limitations offered a "Vision OCR" option for reading a value off dashboard video. No such code exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for #28 to #33. Every number is from a run on this branch's code, not typed.
Updated
rlog,qlog,.bz2,.zstwith the bundled cereal schema;canlab[openpilot].pytest -q753; real-data checks 99 (36 + 63, plus one private phase); stress run 33.tests/real_data/README.md: the J1939 cross-checks,phase_referenceandphase_openpilot.Limitations, updated honestly
Removed
The site's install page and limitations offered a "Vision OCR" option for reading a value off dashboard video. No such code exists in the repository.
No em-dashes. Site regenerated with
python docs/site_src/build_site.py.