Repository navigation
refactor(engine): groups 的上游复制段归零 - #286
Merged
Merged
Conversation
索引、检出、解析、计划与重命名各文件的字段分组与注释按本项目的对象模型 重写;错误消息、优先级链与排序规则保持原样。生产代码的复制段归零。 Co-Authored-By: Claude Code <noreply@anthropic.com>
夹具目录、服务名、端口与分组名换成等价取值,表驱动用例改为命名类型并 重排;断言数量与测试函数数不变(237 个,418 个运行),未删除用例或放宽 比较。复制段从 506 行归零。 Co-Authored-By: Claude Code <noreply@anthropic.com>
对照 26dbcae:总量 8,689 → 7,847 行 / 535 段、100 个文件(生产 3,142、 测试 4,705),internal/groups 整包归零。 Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
结果
internal/groups按本项目的对象模型重写,审计(对照26dbcae)从 842 行降到 0:引擎总量 8,689 → 7,847 行 / 535 段 / 100 文件(生产 3,142,测试 4,705)。
重写内容
serviceOrder、names、SetAliases、ByPath、TargetIn、ServiceDir等按数据形状重组。错误消息、优先级链、排序规则与group_source语义不变(out of range、names are a single word等契约文案保持原样)。验证
go vet ./...go test -count=1 -timeout=8m ./...(全绿)go test -race -count=1 ./internal/groups/gofmt -l internal/groups/无输出python3 scripts/audit-upstream-origin.py --upstream /tmp/sonar:groups 无输出,总量 7,847基于已合并的 #284;分支已同步
main。🤖 Generated with Claude Code