Skip to content

fix(engine): 补上 ProtocolVersion 缺失的 minor 提升到 2.1.0 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SheathedSharp merged 1 commit into from
Nov 12, 2026
Merged

fix(engine): 补上 ProtocolVersion 缺失的 minor 提升到 2.1.0 #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/docs/schema/protocol.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$id": "https://github.com/sheathedsharp/option-berth/engine/docs/schema/protocol.schema.json",
"title": "option-berth daemon protocol",
"description": "Generated from the Go types in internal/state and internal/daemon/rpc. Do not edit by hand; run `go generate ./...`.",
"protocol_version": "2.0.0",
"protocol_version": "2.1.0",
"definitions": {
"ChangeGroup": {
"properties": {
Expand Down
6 changes: 5 additions & 1 deletion engine/internal/daemon/rpc/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ const Version = "2.0"
//
// 2.0.0 removed two fields no handler read: Selector.Key and the host envelope
// that every params type used to embed.
const ProtocolVersion = "2.0.0"
//
// 2.1.0 added the groups.code method and GroupsKillParams.ExpectRuns. Both are
// additive, so a client must gate them on the daemon's advertised capabilities
// (CapabilityKillExpectRuns) rather than on this version.
const ProtocolVersion = "2.1.0"

// Request is a client call. ID is raw so a client can use numbers or strings.
type Request struct {
Expand Down
Loading