Staging by Shashank0701-byte · Pull Request #222 · Shashank0701-byte/System-Craft

Shashank0701-byte · 2026-06-28T11:05:11Z

Closes #220

Summary by CodeRabbit

New Features
- Enhanced canvas simulation controls with clearer overall health states (INACTIVE/CRITICAL/DEGRADED/HEALTHY).
- Health and telemetry visuals now consider bottlenecks and warnings in addition to running status.
Bug Fixes
- Updated latency, error rate, and queue depth visuals to align with the new effective health state.
- System events, scaling/chaos indicators, and alert styling now update more consistently based on overall health tiers.

Fix live telemetry health status display

vercel · 2026-06-28T11:05:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
system-craft	Error		Jun 28, 2026 11:18am

coderabbitai · 2026-06-28T11:05:23Z

📝 Walkthrough

Walkthrough

DesignCanvas computes bottleneck and warning counts from simulation metrics and passes them with globalStatus to SimulationControls. SimulationControls uses a four-tier effectiveStatus to drive telemetry values, health labels, metric alerts, and system events. next.config.ts adds an experimental Turbo skip-validation setting.

Changes

Simulation Health Status Propagation

Layer / File(s)	Summary
Aggregate counts and prop wiring in DesignCanvas `components/canvas/DesignCanvas.tsx`	Filters `nodeMetrics` for `'bottlenecked'` and `'warning'` nodes, then passes the computed counts with `globalStatus` to `SimulationControls`.
`effectiveStatus` logic and UI updates in SimulationControls `components/canvas/SimulationControls.tsx`	Adds new status props, derives `effectiveStatus` from running state and pressure signals, maps it to telemetry base values and health classes, and updates metric alerts plus system event labels and indicators.

Turbo Validation Config

Layer / File(s)	Summary
Turbo skip-validation setting `next.config.ts`	Adds `experimental.turbo` with `unstable_skipValidation: true`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Shashank0701-byte/System-Craft#98: Similar simulation UI changes update DesignCanvas metrics wiring and SimulationControls status-driven rendering.

Poem

🐇 I hop through counts of warning and stress,
Then paint the gauges in tiered finesse.
Three cheers for healthy, degraded, and red,
And Turbo skips validation ahead.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is too generic and looks like a branch name rather than a description of the actual code changes.	Replace it with a short, specific summary of the main change, such as the new simulation status handling or next.js config update.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch staging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

netlify · 2026-06-28T11:05:48Z

✅ Deploy Preview for system-craft-staging ready!

Name	Link
🔨 Latest commit	`06d8012`
🔍 Latest deploy log	https://app.netlify.com/projects/system-craft-staging/deploys/6a410408f278240008fa341f
😎 Deploy Preview	https://deploy-preview-222--system-craft-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@components/canvas/SimulationControls.tsx`:
- Around line 134-137: The telemetry baselines in SimulationControls are still
using the legacy isHighLoad/isMediumLoad branches while alerts and events are
driven by effectiveStatus, which can make the rendered status and simulated
metrics disagree. Update the metric selection logic around the baseLatency,
baseErrorRate, and baseQueue calculations (and the related alert/event paths) so
they all derive from the same status model, either by folding load thresholds
into effectiveStatus or by removing those load-based “healthy” branches. Keep
the behavior consistent across the SimulationControls status/telemetry flow so
the displayed state and generated metrics cannot contradict each other.

🪄 Autofix (Beta)

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb85217e-019a-4962-8b14-58478c299fe2

📥 Commits

Reviewing files that changed from the base of the PR and between 25ded42 and 06d8012.

📒 Files selected for processing (2)

components/canvas/DesignCanvas.tsx
components/canvas/SimulationControls.tsx

coderabbitai · 2026-06-28T11:12:30Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 2 file(s) based on 1 unresolved review comment.

Files modified:

components/canvas/SimulationControls.tsx
next.config.ts

Commit: 4b5176809aaa6e0c4e37dbc6233f2543670ea527

The changes have been pushed to the staging branch.

Time taken: 4m 29s

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@next.config.ts`:
- Around line 6-8: The Turbopack settings are currently placed under
experimental.turbo, which is not a valid Next 16 config location and prevents
the option from applying. Update the NextConfig in next.config.ts to use the
top-level turbopack property instead, and verify whether unstable_skipValidation
is supported for your Next.js version; if not, remove it or replace it with a
documented Turbopack option.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e97a3ced-2a64-4db8-a25c-4d0057ffb47b

📥 Commits

Reviewing files that changed from the base of the PR and between 06d8012 and 4b51768.

📒 Files selected for processing (2)

components/canvas/SimulationControls.tsx
next.config.ts

🚧 Files skipped from review as they are similar to previous changes (1)

components/canvas/SimulationControls.tsx

coderabbitai · 2026-06-28T11:20:53Z

+    turbo: {
+      unstable_skipValidation: true,
+    },


🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Use the top-level turbopack config

experimental.turbo is not a valid Next 16 config location, so this block won’t satisfy NextConfig and the setting won’t take effect. Move any supported Turbopack options to turbopack, and drop unstable_skipValidation unless it’s documented for your Next.js version.

🧰 Tools

🪛 GitHub Check: Lint & Typecheck

[failure] 6-6:
Object literal may only specify known properties, and 'turbo' does not exist in type 'ExperimentalConfig'.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@next.config.ts` around lines 6 - 8, The Turbopack settings are currently placed under experimental.turbo, which is not a valid Next 16 config location and prevents the option from applying. Update the NextConfig in next.config.ts to use the top-level turbopack property instead, and verify whether unstable_skipValidation is supported for your Next.js version; if not, remove it or replace it with a documented Turbopack option.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Shashank0701-byte added 2 commits June 28, 2026 16:32

fix: The Live telemetry wasn't showing the correct status of the health

9353c90

Merge pull request #221 from Shashank0701-byte/feat/ui_updates

06d8012

Fix live telemetry health status display

vercel Bot deployed to Preview June 28, 2026 11:05 View deployment

Shashank0701-byte requested a review from Copilot June 28, 2026 11:06

Copilot AI reviewed Jun 28, 2026

coderabbitai Bot reviewed Jun 28, 2026

View reviewed changes

Comment thread components/canvas/SimulationControls.tsx

vercel Bot had a problem deploying to Preview June 28, 2026 11:18 Failure

coderabbitai Bot reviewed Jun 28, 2026

View reviewed changes

Shashank0701-byte force-pushed the staging branch from 4b51768 to 06d8012 Compare June 28, 2026 11:22

Shashank0701-byte requested a review from Copilot June 28, 2026 11:23

Copilot AI reviewed Jun 28, 2026

Shashank0701-byte merged commit 88c5d16 into main Jun 28, 2026
15 checks passed

Conversation

Shashank0701-byte commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

netlify Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for system-craft-staging ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Applied Successfully

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Shashank0701-byte commented Jun 28, 2026 •

edited

Loading

vercel Bot commented Jun 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 28, 2026 •

edited

Loading

netlify Bot commented Jun 28, 2026 •

edited

Loading

coderabbitai Bot left a comment •

edited

Loading

coderabbitai Bot commented Jun 28, 2026 •

edited

Loading