removed aling-items from service bottom to make sure all service items stay of same height#18
Open
milindpatel11 wants to merge 1 commit intoShaifArfan:masterfrom
Open
removed aling-items from service bottom to make sure all service items stay of same height#18milindpatel11 wants to merge 1 commit intoShaifArfan:masterfrom
milindpatel11 wants to merge 1 commit intoShaifArfan:masterfrom
Conversation
…s stay of same height
Author
|
I commented out instead of deleting. First time contributing to GitHub project. Learned to practice and start writing basic site using your tutorial and thanks for that. I have been making bilingual react sites now using inspiration on a few section from your tutorial and had noticed the service item issue earlier with simple non-react version of this site a few months ago and it notices again with my react version recently, to fix I had to do some debugging and I uses stretch to solve this nd thought it will be good to contribute (though just one line of CSS) to project that I had learned a lot from (specifically on header effects etc). Feel free to accept, reject or suggest something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when service items have different length of content, one with bigger content is higher and symmetry of service items is gone. removing align-items: center from service bottom aligns all height to biggest content box ( I just commented it out for now). Alternatively, we can do align-items: stretch on .service-bottom OR align-self: stretch on .service-item . Feel free to test these and implement change you like.