Repository navigation
Fix 500 on the preview screen for heterogeneous item bags - #120
Merged
Merged
Conversation
The included-sample table iterates the UNION of every sampled item's output keys, but item bags are heterogeneous — e.g. g:item_group_id is only set for multi-variant products. Accessing bag[column] for a column a given row doesn't carry throws 'Key "..." does not exist' under strict_variables (dev + the test app). Null-coalesce the lookup (bag[column] ?? null) so a missing column renders an empty cell. Regression test renders the real template under strict_variables with a mix of items that do and don't carry a column (it reproduces the exact exception on the old template).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #120 +/- ##
=========================================
Coverage 92.17% 92.17%
Complexity 1727 1727
=========================================
Files 228 228
Lines 4382 4382
=========================================
Hits 4039 4039
Misses 343 343 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
/admin/feeds/{id}/previewthrewKey "g:item_group_id" ... does not existfor feeds whose sampled items don't all carry every output key (e.g.g:item_group_idexists only for multi-variant products). The included-sample table iterates the union of all items' keys, andbag[column]on a missing key throws understrict_variables(dev + the test app).Fix: null-coalesce the cell lookup (
bag[column] ?? null) so a missing column renders an empty cell.Test:
PreviewTemplateTestrenders the real template understrict_variableswith a mix of items that do and don't carry a column — it reproduces the exact exception on the pre-fix template and passes on the fix.Verified in the browser against the running test app (feed 2, previously 500, now renders).