Problem
The 1.0 release will be guarded by the Roave BC check, so everything public at that point becomes a commitment. A few things are public but unused:
ConversionsApiEventRaised::$context and hasContext() (src/Event/ConversionsApiEventRaised.php:22). Nothing in the bundle reads the context, there is no getContext(), and the README does not mention it. Either document it as the way to pass information to application listeners (and add a typed getter) or remove it.
Setono\MetaConversionsApiBundle\Message\Command\CommandInterface is an empty marker implemented by SendEvent and referenced nowhere. It can be useful for Messenger routing by interface (routing: { 'Setono\MetaConversionsApiBundle\Message\Command\CommandInterface': async }), but only if documented; otherwise remove it.
- Container parameters
setono_meta_conversions_api.client_side.enabled and setono_meta_conversions_api.server_side.enabled (src/DependencyInjection/SetonoMetaConversionsApiExtension.php:29-30) are set but no service consumes them since services became conditional. Keep them only if they are meant as public flags for other bundles, and say so in the README or UPGRADE.md.
ConversionsApiEventRaised::$event is a public mutable property. Consider public readonly Event $event (the Event object itself stays mutable) to make the intent clear.
Suggested fix
Decide per item before tagging 1.0, then document what stays. This avoids a 2.0 for cosmetic reasons.
Problem
The 1.0 release will be guarded by the Roave BC check, so everything public at that point becomes a commitment. A few things are public but unused:
ConversionsApiEventRaised::$contextandhasContext()(src/Event/ConversionsApiEventRaised.php:22). Nothing in the bundle reads the context, there is nogetContext(), and the README does not mention it. Either document it as the way to pass information to application listeners (and add a typed getter) or remove it.Setono\MetaConversionsApiBundle\Message\Command\CommandInterfaceis an empty marker implemented bySendEventand referenced nowhere. It can be useful for Messenger routing by interface (routing: { 'Setono\MetaConversionsApiBundle\Message\Command\CommandInterface': async }), but only if documented; otherwise remove it.setono_meta_conversions_api.client_side.enabledandsetono_meta_conversions_api.server_side.enabled(src/DependencyInjection/SetonoMetaConversionsApiExtension.php:29-30) are set but no service consumes them since services became conditional. Keep them only if they are meant as public flags for other bundles, and say so in the README orUPGRADE.md.ConversionsApiEventRaised::$eventis a public mutable property. Considerpublic readonly Event $event(theEventobject itself stays mutable) to make the intent clear.Suggested fix
Decide per item before tagging 1.0, then document what stays. This avoids a 2.0 for cosmetic reasons.