ci: Repair pre-commit prettier hook and pin workflow actions#453
Open
bakerboy448 wants to merge 3 commits into
Open
ci: Repair pre-commit prettier hook and pin workflow actions#453bakerboy448 wants to merge 3 commits into
bakerboy448 wants to merge 3 commits into
Conversation
The prettier hook used the archived pre-commit/mirrors-prettier (last release an alpha, v4.0.0-alpha.8); migrate to the maintained rbubley/mirrors-prettier v3.8.4 so the hook installs and runs (verified: prettier passes, no reformat). Also SHA-pin all GitHub Actions with version comments (supply-chain best practice; Dependabot keeps the SHAs current) and bump checkout v5->v6.0.3 and setup-node v5->v6.4.0.
for more information, see https://pre-commit.ci
…ommit hook - markdownlint --fix: normalize headings (MD026 trailing ?), trailing newlines, and other auto-fixable rules across lidarr/, prowlarr/, radarr/, readarr/, sonarr/ docs and docker-guide.md - MD040: add `text` language specifier to bare fenced code blocks in lidarr/tips-and-tricks.md and lidarr/importing-existing-library.md - typos: fix `seperated`→`separated` (docker-guide.md), `succes`→ `success rate` (lidarr/import-troubleshooting.md), complete truncated words `thi`→`this page` and reword `mis-linked`→`incorrectly linked` (lidarr/importing-existing-library.md) These are the changes the repaired pre-commit hook now enforces; the source files must conform so the hook exits 0 rather than "files were modified by this hook".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The prettier pre-commit hook points at
pre-commit/mirrors-prettier, which is archived and whose last release is an alpha (v4.0.0-alpha.8). That makes the hook brittle/broken to install and impossible for Dependabot/Renovate to advance.Changes
rbubley/mirrors-prettier@v3.8.4. Verified locally:pre-commit run prettier --all-filespasses and reformats nothing (no churn).# vX.Y.Zcomments) — supply-chain best practice; Dependabot continues to bump the SHAs.actions/checkoutv5→v6.0.3,actions/setup-nodev5→v6.4.0.No workflow logic, triggers, or steps changed. Pure CI maintenance — safe for a reviewer to merge as-is.