Fix feed DeArrow controls, preview mute toggle and vote counts - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeArrow toggles overlapped channel titles and notification thumbnails, while home cards could lose their toggle. Place each toggle below its overflow menu, resolve layer-backed nodes within the card, and preserve video identity across thumbnail changes and cell reuse.
Preview audio now initializes YouTube's native preference once per video, allowing repeated mute/unmute taps. Both action-bar designs get measured like/dislike text nodes, refreshed through the video-activation callback used by YouTube 21.38.2. Thumbnail layout no longer restarts downloads; empty responses are cached, failed requests are throttled, and image callbacks avoid forcing UIKit views for layer-backed nodes.
Validation: six executable layout/hit-target cases and source regression guards pass. The macOS build passed for rootless, rootful, and roothide packages and generated a v2.1.6 test IPA: https://github.com/Sersium/YouMod/actions/runs/36224075784. On-device playback, scrolling, and visual checks remain pending; see Tests/DEVICE_SMOKE_TEST.md. PR builds do not update Feather or publish a release.