fix: rename TSConfig.json to tsconfig.json - #82
Open
erossignon wants to merge 1 commit into
Open
Conversation
tsc and bundlers such as esbuild look for the exact lowercase filename tsconfig.json. On case-insensitive filesystems (Windows, macOS) the mis-cased file happens to be found, but on Linux the lookup fails: tsc falls back to compiling with default options, and esbuild-based consumers that bundle this package error out with 'Cannot find tsconfig file'. Renaming the file makes every platform behave identically. Fixes SerafinTech#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
TSConfig.jsonto the exact lowercasetsconfig.jsonthattscand bundlers expect. Fixes #81.Why
tsc(thebuildscript runs plaintsc) and esbuild look for the exact filenametsconfig.json. On case-insensitive filesystems (Windows, macOS) the mis-cased file happens to be picked up, but on Linux:tscsilently compiles with default options instead of the settings in this file, andCannot find tsconfig file "node_modules/st-ethernet-ip/tsconfig.json"(that is how we hit this — our CI packaging step works on Windows dev machines and dies on the Linux runner).Renaming makes every platform behave identically. No content change — git records it as a 100% rename.
🤖 Generated with Claude Code