Skip to content

docs(claude): note in CLAUDE.md that Pages is live - #8

Merged
docktermj merged 1 commit into
mainfrom
7-docktermj-1
Oct 5, 2026
Merged

docktermj merged 1 commit into
mainfrom
7-docktermj-1

Conversation

@docktermj

@docktermj docktermj commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Closes #7

What and why

GitHub Pages is on and https://hub.senzing.com/bootcamp/ is live, but .claude/CLAUDE.md still described Pages as pending and didn't mention the promo video added in #6.

Section Change
Layout Lists docs/video/ (the two-minute promo, captions burned in, played on demand in #watch) and the poster in docs/images/
Publishing Pages is enabled from branch main, folder /docs; every merge to main publishes; check the build with gh api repos/Senzing/bootcamp/pages/builds/latest and the live page

Checks

  • cspell: 0 issues.

Resolves #7
Resolves #6

Publishing now says Pages is enabled from main's /docs folder, that every
merge to main publishes the page, and how to check the build. Layout now
lists docs/video/ and the promo video poster in docs/images/.

issue: #7
@docktermj
docktermj requested a review from a team as a code owner October 5, 2026 22:08
@docktermj docktermj self-assigned this Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🤖 Claude Code Review

Code review: .claude/CLAUDE.md

The diff only touches .claude/CLAUDE.md: two documentation updates. One adds docs/video/ and the video poster to the Layout section. The other rewrites the Publishing section now that Pages is live. I read only the diff and did not check the repo contents.

Code Quality

  • ✅ Style conventions: The new bullets match the surrounding Markdown. They use the same list style, the same backticked paths and a continuation indent of two spaces.
  • ✅ No commented-out code: None.
  • ✅ Meaningful names: Not applicable beyond accurate path names. docs/video/ and #watch match the structure described in feat(docs): add bootcamp promo video to the landing page #6.
  • ✅ DRY: The Publishing text states the deploy source once and doesn't repeat it elsewhere.
  • ✅ Defects: None found.
    • The gh api repos/Senzing/bootcamp/pages/builds/latest command is a valid read-only endpoint.
    • The stale "enabled manually… once the three platform pages are live" wording is correctly replaced.
  • ✅ CLAUDE.md is not environment-specific: The additions use repo-relative paths and the org-level repo name. There are no local paths, usernames or machine settings.

Testing

  • ✅ Not applicable. The change is documentation only, and the repo has no test suite (per CLAUDE.md).
  • ✅ The spellcheck is the only relevant CI check. The new terms (MP4, gh, api) should pass cspell. Run the command from CLAUDE.md to confirm.

Documentation

  • ✅ README: No update needed. CLAUDE.md is the doc being updated.
  • ✅ API docs: Not applicable.
  • ✅ Inline comments: Not applicable.
  • ⚠️ CHANGELOG.md: The diff doesn't touch a changelog. The repo doesn't appear to have one, so this is likely not applicable.
  • ✅ Markdown: The text looks CommonMark-compliant, with no trailing whitespace and lines wrapped at about 100 columns like the rest of the file. I did not run prettier.

Security

  • ✅ No credentials, sensitive data, or .lic files, and no strings starting with AQAAAD.
  • ✅ Input validation and error handling are not applicable.

Summary

The change is accurate and safe to merge. One minor point to confirm: the claim that "every merge to main publishes the page" depends on the Pages settings, which live outside the repo. If the settings change, this line will go stale.

Automated code review analyzing defects and coding standards

@docktermj
docktermj merged commit 0af996c into main Oct 5, 2026
9 checks passed
@docktermj
docktermj deleted the 7-docktermj-1 branch October 5, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CLAUDE.md now that Pages is live

2 participants