Raise clear error when no flight images present for ILS correction - #78
Open
BeesualDrone wants to merge 1 commit into
Open
Raise clear error when no flight images present for ILS correction#78BeesualDrone wants to merge 1 commit into
BeesualDrone wants to merge 1 commit into
Conversation
Add error handling for empty image DataFrame in ILS correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error handling for empty image DataFrame in ILS correction.
What?
Raises an explicit
FileNotFoundErrorwhenimage_dfis empty after the calibration/non-calibration split inio.create_cal_df, before reaching the ILS merge step.Why?
If
ils_present=Trueand the Input Path contains only calibration panel images (no flight images),image_dfends up empty after the split. The subsequent merge withband_avg_ilsproduces 0 rows, andDataFrame.apply(axis=1)on that empty, multi-column frame returns the original DataFrame instead of an empty Series — causingband_df["ils_scaling_factor"] = ...to fail with a confusing internal pandas error instead of a clear, actionable message.Full reproduction and root-cause writeup: Closes #77
PR Checklist
Breaking Changes
None. This only adds a new, earlier validation error for an input configuration that previously failed anyway, just with a less clear message.