fix(agentx): exclude auto-warmup baselines from profiling metrics - #44
Open
cquil11 wants to merge 1 commit into
Open
fix(agentx): exclude auto-warmup baselines from profiling metrics#44cquil11 wants to merge 1 commit into
cquil11 wants to merge 1 commit into
Conversation
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@dcbd942654ef87b357c7722837855dbccedc2353Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@dcbd942654ef87b357c7722837855dbccedc2353Last updated for commit: |
|
Fern Docs Preview: generation failed — see the Actions log for details. This does not block merge; ask a maintainer to retry if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AgentX auto-creates its warmup CreditPhaseConfig without phase_kind. PhasePublisher forwards None, and ServerMetricsManager interprets both boundary baselines as profiling. Phase-tagged exports consequently include warmup counter growth in profiling totals, despite declaring a profiling-only time range.
Observed in official InferenceX run 33524322076 while validating cached-token source metrics; the bug also affects existing server counters.
Fix
Set phase_kind="warmup" in the auto-warmup builder. No workload, timing, scheduling, or exporter semantics change.
Validation
Supports InferenceX #2796 and #2797. Canonical GPU validation with the fixed client remains pending.
Note
Low Risk
Single metadata field on the agentic warmup config path; fixes export tagging without changing timing or scraping logic.
Overview
AgentX auto-warmup was missing
phase_kindon its synthesizedCreditPhaseConfig, so phase boundary baselines were treated as profiling and warmup counter growth leaked into JSON/CSV profiling totals.The change sets
phase_kind="warmup"in_build_agentic_warmup_config, aligning auto-warmup with user-declared warmup phases soServerMetricsManager.collect_baselinetags start/end scrapes as warmup. Workload and timing behavior are unchanged.Docs now state that AgentX auto-warmup boundary scrapes follow the same warmup exclusion as manual warmup. Regression tests cover START/END baselines for agentic auto-warmup via
PhasePublisher→collect_baseline.Reviewed by Cursor Bugbot for commit dcbd942. Bugbot is set up for automated code reviews on this repo. Configure here.