fix(agentx): allow sparse low-concurrency profile tails - #41
Merged
Conversation
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@c5f353f0ae120bc4d2531122dbcec90194ffcaa9Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@c5f353f0ae120bc4d2531122dbcec90194ffcaa9Last updated for commit: |
|
Fern Docs Preview: generation failed — see the Actions log for details. This does not block merge; ask a maintainer to retry if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lower the AgentX profile-liveness cutoff from 98% to 95%. On a one-hour profile, the allowed quiet tail changes from 72 seconds to 180 seconds; the run still fails when neither TTFT nor inter-token latency reaches that cutoff.
False-positive runs
Error and fix
At low concurrency, a long request can remain in flight through the end of an otherwise healthy profile, leaving no new latency sample in the final 72 seconds. The 95% cutoff tolerates that sparse tail while still detecting the intended failure mode: a server that produces neither latency signal for the final three minutes.
Validation