-
Notifications
You must be signed in to change notification settings - Fork 282
perf(agentx): refresh K3 MI355X vLLM recipe with DCP8 MTP arm #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seungrokj
wants to merge
23
commits into
main
Choose a base branch
from
amd/agentx_k3_vllm_0903_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−14
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
71acdd4
perf(agentx): refresh K3 MI355X vLLM recipe with DCP8 MTP arm
seungrokj c281dbe
docs(changelog): link K3 MI355X vLLM DCP8 MTP refresh PR
seungrokj 7b93468
style(agentx): add trailing newline to K3 MI355X benchmark script
seungrokj db7732d
perf(agentx): drop c52 from K3 MI355X DCP8 arm
seungrokj 0a32492
perf(agentx): gate K3 LMCache GPU workers on DCP; trim sweep to c14/c48
seungrokj 1701d42
perf(agentx): lower K3 c12/c14 GMU to 0.88; run c14-only smoke test
seungrokj aefefb3
perf(agentx): run K3 c12/c14 GMU 0.88 smoke test
seungrokj 5cebe65
perf(agentx): lower K3 c12/c14 GMU to 0.85
seungrokj 1b24693
perf(agentx): test K3 c14 GPU-resident (no KV offload), GMU 0.9
seungrokj ffc4d74
perf(agentx): bump K3 image to nightly-73029d42; c14 no-spec GPU-resi…
seungrokj 99d0671
perf(agentx): run K3 c48 DCP8 LMCache smoke test on nightly-73029d42
seungrokj 34d93c9
perf(agentx): run K3 c14 GPU-resident with MTP spec on nightly-73029d42
seungrokj 883d6e3
perf(agentx): drop K3 high-conc max-num-batched-tokens to 4096 (OOM fix)
seungrokj 60acfb3
perf(agentx): activate K3 c48 DCP8 arm for OOM-fix validation
seungrokj 47745bf
perf(agentx): gate K3 LMCache chunk-size on DCP; pin dev60 wheel; run…
seungrokj f48e07a
perf(agentx): gate K3 LMCache wheel on DCP; run c14 on dev60
seungrokj ed613b6
fix(agentx): define LMCACHE_RELEASE for the K3 index URL
seungrokj bbce1d2
perf(agentx): pin K3 LMCache to v0.5.5rc4 from the release asset page
seungrokj 0a3b572
perf(agentx): pin K3 LMCache to dev89; run c14 (dcp1) and c48 (dcp8)
seungrokj d5e7a1c
perf(agentx): revert K3 image to 7c5dc571; c48 label to dev89
seungrokj 05c3f3f
perf(agentx): bump K3 image to 73029d42; run full conc sweep on dev89
seungrokj de3cc42
Merge branch 'main' into amd/agentx_k3_vllm_0903_2
seungrokj 932280a
perf(agentx): add conc 52 to K3 dcp8 sweep
seungrokj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCP defaults disagree for LMCache
Low Severity
LMCache worker and chunk sizing treats unset
DCP_SIZEas 1, but the later DCP setup defaults the same variable to 8. An unset run therefore starts LMCache with the non-DCP 3072 chunk and one GPU worker, then enables DCP8, which the new comments say needs the 12288-token chunk.Additional Locations (1)
benchmarks/single_node/agentic/kimik3_fp4_mi355x_mtp.sh#L315-L316Reviewed by Cursor Bugbot for commit de3cc42. Configure here.