-
Notifications
You must be signed in to change notification settings - Fork 282
Validate vLLM P/D cache-source metrics on GB300 #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
20
commits into
main
Choose a base branch
from
codex/h100-minimaxm3-disagg-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b3f8ba4
Add H100 MiniMax-M3 disaggregated source validation
cquil11 cf67f7d
Schedule H100 disaggregated source validation
cquil11 572b087
Allow cold H100 disaggregated container startup
cquil11 0bb3a24
Revert "Allow cold H100 disaggregated container startup"
cquil11 1f50088
Revert "Schedule H100 disaggregated source validation"
cquil11 4308bee
Revert "Add H100 MiniMax-M3 disaggregated source validation"
cquil11 c221f79
Use proven GB300 disaggregated validation point
cquil11 66e7bf4
Match proven GB300 c256 topology
cquil11 3057a73
Pin validation image in GB300 recipe
cquil11 cb93ced
fix: align disaggregated validation with upstream MoE backend
cquil11 7e709c0
fix: collect worker metrics for custom AgentX validation
cquil11 600b1dc
Merge upstream main to refresh validation sweep
cquil11 edc96a6
fix(agentx): isolate P/D profiling metrics from warmup
cquil11 ef79a0b
fix: retain Mooncake store checkpoints in the P/D validation image
cquil11 4567fc0
Merge upstream main before corrected P/D validation
cquil11 0fcc29d
fix(agentic): recover hybrid KV cache misses in P/D validation image
cquil11 dab55b2
fix(agentic): recompute missing prefill cache loads
cquil11 e4f1f9b
Merge remote-tracking branch 'origin/main' into codex/h100-minimaxm3-…
cquil11 7187c07
fix(config): route GB300 partition overrides to batch_1
cquil11 b41d058
fix(benchmark): use P/D image with complete connector block tables
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recipe omits cache-source metrics
High Severity
This config is now the sole point for source-labeled prompt-token cache validation, but the recipe it launches never enables
kv-cache-metrics,enable-prompt-tokens-details, orAIPERF_REQUIRED_SERVER_METRIC_PREFIX. The removed H100 recipe set all three, so vLLM will not exportsource=p2phits and AIPerf will not require them.Additional Locations (1)
perf-changelog.yaml#L6749-L6752Reviewed by Cursor Bugbot for commit c221f79. Configure here.