[build] Upgrade rules_rs to 0.0.106 and @llvm to 0.8.18 - #17929
Open
AutomatedTester wants to merge 1 commit into
Open
[build] Upgrade rules_rs to 0.0.106 and @llvm to 0.8.18#17929AutomatedTester wants to merge 1 commit into
AutomatedTester wants to merge 1 commit into
Conversation
The toolchains module extension no longer publishes a top-level :all target, so register the generated toolchains with the recursive //... pattern to match the current rules_rs API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Rust build toolchain to current releases:
rules_rs0.0.96 → 0.0.106@llvm(hermetic-llvm) 0.8.11 → 0.8.18Required API change
The
rules_rstoolchains module extension no longer publishes a top-level:alltarget for the generated toolchains repo. Registration is updated to therecursive pattern to match the current API:
Validation
bazel build //rust:selenium-manager -c optbuilds cleanly on macOS(arm64); the resulting binary runs (
selenium-manager 0.4.48-nightly)../scripts/format.sh --pre-pushpasses.Notes
@llvm0.8.18 includes Windowscc_commonlinking and authoritativeWindows ABI handling (hermetic-llvm FirefoxDriver cannot set the path on a hidden fileupload input #706, Webdriver hangs when perform click action on a webelement #709), and
rules_rs0.0.106exposes a configurable
declare_rustc_toolchainsmacro. These are relevantgroundwork for the in-progress Windows-host build of
selenium-manager([rust] Allow cross-compilation of selenium-manager on all platforms #17586) but are not exercised by this PR.
selenium-managerbinaries are Cargo-built in CI; this changeaffects the Bazel (local/dev) build path only.