Fix: 'check if all files are intact' was depending on the file system order - #5
Open
liebharc wants to merge 1 commit into
Open
Fix: 'check if all files are intact' was depending on the file system order#5liebharc wants to merge 1 commit into
liebharc wants to merge 1 commit into
Conversation
|
Hi ! Any updates ? Can't this get merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this version of easyocr! On my machine (Ubuntu running in Windows WSL) every run triggers: "Re-downloading character text files". It seems that the md5 checksums are all correct, but the order in which os.listdir returns the files is different to the order defined in character_md5sum. This PR would address this issue by sorting the files explicitly in Python before comparing them to the known checksums.