fix: persist captured proof snapshot across restart#205
Open
matthias-wright wants to merge 6 commits into
Open
fix: persist captured proof snapshot across restart#205matthias-wright wants to merge 6 commits into
matthias-wright wants to merge 6 commits into
Conversation
|
Looks good to me. One deployment note: this changes the serialized ConsensusState format by adding proof_el_block_number/captured_bytes trailers. If nodes restart from state encoded before this PR, decode requires a migration/backward-compatible read path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #170.
This addresses #199.
Changes:
captured_bytestoConsensusStatethat contains a snapshot of the consensus state (withcaptured_bytesset toNone). This snapshot is taken incapture_state_root(). This snapshot is used to derive the fieldsproof_tree,state_root, andproof_validator_keys. This ensures that the frozen state root is not lost by a validator restart, especially at the epoch boundary.