Minor changes in ProjectDetailModal.jsx - #11
Merged
ekoslow1-creator merged 2 commits intoAug 27, 2026
Merged
Conversation
created_at reflects when the row was written in Django admin, not when the project was actually made, so it's misleading as the headline date. submission_date is now what "Created" displays; created_at is kept as a secondary "Project logged" note.
📊 Code Quality Score: 1/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
saengel
requested changes
Aug 27, 2026
saengel
left a comment
saengel
left a comment
Collaborator
There was a problem hiding this comment.
Two tiny copy changes! Thanks for addressing!
| hasValue(project.submission_source) && `via ${project.submission_source}`, | ||
| hasValue(project.created_at) && `Created ${formatDate(project.created_at)}`, | ||
| hasValue(project.updated_at) && `Updated ${formatDate(project.updated_at)}`, | ||
| hasValue(project.submission_date) && `Created ${formatDate(project.submission_date)}`, |
| hasValue(project.created_at) && `Created ${formatDate(project.created_at)}`, | ||
| hasValue(project.updated_at) && `Updated ${formatDate(project.updated_at)}`, | ||
| hasValue(project.submission_date) && `Created ${formatDate(project.submission_date)}`, | ||
| hasValue(project.created_at) && `Project logged ${formatDate(project.created_at)}`, |
Notes that "in the wild" submission dates come from the last Github commit or site URL, and renames the modal's date labels for clarity. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
saengel
self-requested a review
August 27, 2026 07:34
saengel
approved these changes
Aug 27, 2026
📊 Code Quality Score: 3/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created_at reflects when the row was written in Django admin, not when the project was actually made, so it's misleading as the headline date. submission_date (which is when the project was completed or created) is now what "Created" displays; created_at is kept as a secondary "Project logged" note.