Skip to content

Feature/stream final answer - #159

Open
yonadavGit wants to merge 1 commit into
mainfrom
feature/stream-final-answer
Open

Feature/stream final answer#159
yonadavGit wants to merge 1 commit into
mainfrom
feature/stream-final-answer

Conversation

@yonadavGit

Copy link
Copy Markdown
Contributor

No description provided.

@yonadavGit
yonadavGit requested a review from nsantacruz July 5, 2026 14:07
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 35/100

58 × 0.6 = 34.8 ≈ 35

Category Score Factors
🔭 Scope 13/20 22 files across frontend/backend/tests/config; two distinct features (streaming + tool rename); cross-cutting change touching API, SSE, metrics, prompts
🏗️ Architecture 11/20 Consolidates ai.sefaria.org into sefaria.org base URL; introduces new SSE event type 'partial'; new on_text_delta callback pattern threaded through SDK runner → orchestrator → view → frontend
⚙️ Implementation 12/20 Streaming delta extraction with dual-path logic; SSE event routing; nonlocal closure for TTFC metric; incremental markdown rendering; tool rename across all layers
⚠️ Risk 10/20 Tool renames are breaking changes for existing clients; hardcoded prompt slug is deployment risk; streaming adds new code path to critical response flow; XSS risk with @html rendering
✅ Quality 10/15 New test files for streaming (test_sdk_runner_streaming.py) and metrics (test_metrics_mapper.py); existing tests updated for renames; frontend streaming untested; hardcoded slug is quality concern
🔒 Perf / Security 2/5 TTFC metric improves observability; streaming improves perceived latency; XSS risk with @html renderMarkdown not fully addressed; no sanitization verification

Was this score accurate? 👍 Yes · 👎 No

Scored by GitVelocity · How are scores calculated?

@yonadavGit
yonadavGit force-pushed the feature/stream-final-answer branch 2 times, most recently from f174943 to c747d77 Compare July 5, 2026 14:31
@coolify-sefaria-github

coolify-sefaria-github Bot commented Jul 6, 2026

Copy link
Copy Markdown

The preview deployment for sefaria/ai-chatbot:server is ready. 🟢

Open app | Open Build Logs | Open Application Logs

Last updated at: 2026-07-08 07:32:37 CET

@yonadavGit
yonadavGit force-pushed the feature/stream-final-answer branch from c747d77 to b0da956 Compare July 6, 2026 09:46
@yonadavGit
yonadavGit force-pushed the feature/stream-final-answer branch from b0da956 to dd4a395 Compare July 6, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant