Update documentation for parasha topic calendar endpoint - #3707
Conversation
📊 Code Quality Score: 3/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
There was a problem hiding this comment.
🟡 Changes recommended
The new OpenAPI parameter schema is inconsistent with existing diaspora parameter typing in the same spec (string vs integer), which can break client generation/validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the public OpenAPI specification so the interactive API reference correctly documents the diaspora query parameter supported by GET /api/calendars/topics/parasha, and corrects a misleading GitHub Actions workflow comment.
Changes:
- Added a
diasporaquery parameter to the OpenAPI entry forGET /api/calendars/topics/parasha. - Updated the GitHub Actions workflow comment to reflect the actual
prodbranch trigger.
File summaries
| File | Description |
|---|---|
| docs/openAPI.json | Documents the diaspora query parameter for the parasha topic calendar endpoint in the OpenAPI spec. |
| .github/workflows/readme-openapi-docs-sync.yml | Updates an outdated comment to match the workflow’s prod branch trigger. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📊 Code Quality Score: 3/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
Description
The
calendars/topics/parashaendpoint has a diaspora parameter that was not documented. This PR adds it to the OpenAPI.json file so it will populate on the interactive API reference.Code Changes
Notes
Sefaria-Project/reader/views.py
Line 2898 in ce3aaab