Skip to content

Redirect PBS to developers - #3706

Open
saengel wants to merge 1 commit into
masterfrom
chore/sc-44780/redirect-https-www-sefaria-org-powered-by
Open

Redirect PBS to developers#3706
saengel wants to merge 1 commit into
masterfrom
chore/sc-44780/redirect-https-www-sefaria-org-powered-by

Conversation

@saengel

@saengel saengel commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Sefaria used to have a static page for displaying PBS, however it is now outdated - and we'd like instead to redirect to developers.sefaria.org/docs/powered-by-sefaria where we keep the updated list (for now).

Code Changes

  1. A permanent redirect to the developer portal
  2. Removal of the static page

Notes

The static page was archived in conjunction with the engagement team.

@saengel
saengel requested review from YishaiGlasner and stevekaplan123 and a lite review from Copilot September 8, 2026 07:48
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 1/100

Base Score 11 × ESF 0.1 = 1.1, rounded to 1

Category Score Factors
🔭 Scope 2/20 One file modified (sites/sefaria/urls.py) with one slug removed from the static page list and one URL pattern added. The deleted templates/static/powered-by.html is a whole-file deletion excluded from effective lines.
🏗️ Architecture 1/20 No module boundary changed. The route moves from the static-page slug list to the explicit redirect block, following the same pattern already used by /wiki, /developers, and /donate.
⚙️ Implementation 2/20 HttpResponsePermanentRedirect is imported and used in a one-line lambda in site_urlpatterns. The regex r'^powered-by/?$' handles optional trailing slash, consistent with adjacent patterns.
⚠️ Risk 3/20 A 301 response is cached permanently by browsers and search engines. If https://developers.sefaria.org/docs/powered-by-sefaria moves, cached clients will not follow a subsequent change without a cache-busting mechanism. The PoweredByPage React component referenced in the deleted template may remain as dead code in the frontend bundle.
✅ Quality 2/15 No test accompanies the change. No URL routing test verifies the redirect status code or target URL.
🔒 Perf / Security 1/5 No performance or security work is present beyond the standard HTTP 301 response, which carries no security implications in this context.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change cleanly replaces the removed static route with a permanent redirect and shows no remaining runtime references to the deleted template.

Pull request overview

This PR retires Sefaria’s outdated “Powered by Sefaria” static page and replaces it with a permanent redirect to the maintained list on the developer portal (developers.sefaria.org).

Changes:

  • Removed the legacy templates/static/powered-by.html static page template.
  • Stopped routing /powered-by through serve_static and added a 301 redirect from /powered-by to https://developers.sefaria.org/docs/powered-by-sefaria.
File summaries
File Description
templates/static/powered-by.html Deleted the deprecated static template formerly used for the “Powered by Sefaria” page.
sites/sefaria/urls.py Removes powered-by from the static page router and adds a permanent redirect for /powered-by.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@saengel
saengel enabled auto-merge September 8, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants