Skip to content

chore: reset margin top in navsidebar under 700 pixels - #3700

Open
stevekaplan123 wants to merge 1 commit into
masterfrom
bug/sc-46630/gray-bar-covering-null-state-content-when
Open

chore: reset margin top in navsidebar under 700 pixels#3700
stevekaplan123 wants to merge 1 commit into
masterfrom
bug/sc-46630/gray-bar-covering-null-state-content-when

Conversation

@stevekaplan123

@stevekaplan123 stevekaplan123 commented Sep 6, 2026

Copy link
Copy Markdown
Member

Description

On the search page below 700px wide, the "no results" message was partially hidden behind a gray block — the call-to-action button and the "report a bug / contact us" caption were cut off or invisible. Turns out that this was a problem on many pages in the site so the fix here is global.

The cause is a background hack on .navSidebar in s2.css:1510-1517:

border-top: 80px solid #FBFBFA;
margin: -80px 0 0 0;

Code Changes

margin-top: 0 — stops the sidebar being pulled up into the content. This alone removes the overlap.
border-top: none — removes the gray band itself, so no stray stripe is left behind.
width: 100% — the stacked sidebar was staying a fixed 420px, leaving dead space beside it.

@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 1/100

8 × 0.1 = 0.8, floored to minimum of 1

Category Score Factors
🔭 Scope 2/20 One block of 10 lines added to static/css/s2.css. No other files touched. The change targets two existing class selectors, .sidebarLayout and .navSidebar, within a new media query.
🏗️ Architecture 0/20 No module boundary changed. The addition sits inside an existing CSS file with no new dependencies or structural reorganization.
⚙️ Implementation 2/20 Four CSS property declarations inside a single @media (max-width: 700px) block: flex-direction: column on .sidebarLayout, and width: 100%, margin-top: 0, border-top: none on .navSidebar. No algorithmic logic.
⚠️ Risk 2/20 .navSidebar is not scoped to .searchContent in the media query, so the rule applies to every instance of .navSidebar site-wide on narrow viewports, not only within search pages. The change is visual-only and easily reverted.
✅ Quality 2/15 No test accompanies the change. CSS responsive changes are not typically unit-tested, but no visual regression test or screenshot comparison is referenced.
🔒 Perf / Security 0/5 No performance or security work present in this diff.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant