chore: reset margin top in navsidebar under 700 pixels - #3700
Open
stevekaplan123 wants to merge 1 commit into
Open
chore: reset margin top in navsidebar under 700 pixels#3700stevekaplan123 wants to merge 1 commit into
stevekaplan123 wants to merge 1 commit into
Conversation
📊 Code Quality Score: 1/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the search page below 700px wide, the "no results" message was partially hidden behind a gray block — the call-to-action button and the "report a bug / contact us" caption were cut off or invisible. Turns out that this was a problem on many pages in the site so the fix here is global.
The cause is a background hack on .navSidebar in s2.css:1510-1517:
Code Changes
margin-top: 0 — stops the sidebar being pulled up into the content. This alone removes the overlap.
border-top: none — removes the gray band itself, so no stray stripe is left behind.
width: 100% — the stacked sidebar was staying a fixed 420px, leaving dead space beside it.