Fix keyboard access and names for core controls - #2
Open
byot-dot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a small set of high-impact accessibility problems in shared/global controls:
divaria-controls/aria-expandedThese address keyboard and control-semantics issues under WCAG 2.2, primarily 2.1.1 (Keyboard) and 4.1.2 (Name, Role, Value).
The changes are intentionally narrow and preserve the existing visual behavior.
I found additional accessibility issues while reviewing the dashboard, including form labeling, standalone dialog behavior, chart alternatives, and contrast. If continued accessibility cleanup would be useful, I'm happy to keep working through them in similarly small, reviewable PRs.