Skip to content

Fix Post-Cutscene TTS Block Reset #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeyBelvar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Post-Cutscene TTS Block Reset #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698101e
Clear consumed cutscene audio block
JoeyBelvar May 15, 2026
5c047ef
Document late cutscene block reset
JoeyBelvar May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ArtemisRoleplayingKit/Voice/AddonTalkHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ private void Framework_Update(IFramework framework) {
if (_currentDialoguePaths.Count > 0) {
_currentDialoguePaths[_currentDialoguePaths.ElementAt(_currentDialoguePaths.Count - 1).Key] = true;
}
_blockAudioGeneration = false;
ClearConsumedAudioGenerationBlock("talk state handled");
}
} else if (stateSnapshot != null) {
TraceNpcTtsDebug($"Ignored talk state speaker='{stateSnapshot.Speaker}' textPresent={!string.IsNullOrEmpty(stateSnapshot.Text)} text='{PreviewText(stateSnapshot.Text)}'");
Expand Down Expand Up @@ -717,6 +717,18 @@ private async void AutoAdvancePauseOnlyDialogue(string pauseText, long sequence)
}
}

private void ClearConsumedAudioGenerationBlock(string reason) {
if (!_blockAudioGeneration) {
return;
}

// Cutscene audio blocks are intended to suppress one matching NPC line.
// Clear the flag once that block has been consumed so it cannot leak into
// later manually advanced dialogue after the voiced scene has ended.
_blockAudioGeneration = false;
TraceNpcTts($"Cleared consumed cutscene audio block reason='{reason}' blockCount={_blockAudioGenerationCount}");
}

private bool ShouldSkipNpcText(string npcName, string message) {
if (!VerifyIsEnglish(message, out var languageRejectionReason)) {
Plugin.PluginLog.Information($"[NPC TTS] Skipping text for npc='{npcName}' reason='{languageRejectionReason}' text='{PreviewText(message)}'");
Expand Down Expand Up @@ -1411,6 +1423,9 @@ await _plugin.NpcVoiceManager.GetCharacterAudio(stream, value, arcValue, initial
}, _plugin.Config.NPCSpeechSpeed, values.Item2 == "Elevenlabs" ? 0.5f : (values.Item2 == "XTTS" ? 1.8f : 1.8f));
} else {
TraceNpcTts($"Audio ready but playback suppressed by blockAudioGeneration sequence={request.Sequence} npc='{nameToUse}' text='{PreviewText(value)}'");
// A cutscene SCD can arrive while a relay request is in flight.
// Once that late response is suppressed, the block has done its job.
ClearConsumedAudioGenerationBlock("npc audio playback suppressed");
}
}
break;
Expand Down
Loading