Fix select_as aliases in combined selects - #3194
Merged
Merged
Conversation
Fixes SeaQL#3174. AI-Assisted-By: OpenAI Codex
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3174.
Root cause
A column-level select_as transform changes the projection from a column expression into a cast expression. Combined selects prefix the first-entity projection aliases, but can only infer an unaliased projection name from a plain column or an enum cast. As a result, find_also_related and the other combined-select paths panic before executing SQL.
Fix
Preserve the column logical name as the projection alias whenever select_as produces a transformed expression. Plain columns and the existing enum path retain their previous SQL shape. Apply the same behavior to default entity projections and QuerySelect::column, and mirror it in sea-orm-sync.
Verification