fix: pass through Eq derive in ModelEx to fix clippy::derive_partial_eq_without_eq (issue #3172) - #3191
Closed
yunaremaia wants to merge 1 commit into
Closed
fix: pass through Eq derive in ModelEx to fix clippy::derive_partial_eq_without_eq (issue #3172)#3191yunaremaia wants to merge 1 commit into
yunaremaia wants to merge 1 commit into
Conversation
…ial_eq_without_eq The model_ex macro was silently stripping the Eq derive from the generated ModelEx struct, which triggers clippy::derive_partial_eq_without_eq when -D warnings or clippy::nursery is enabled. Eq is a trivial marker trait that is always valid when PartialEq is present, so passing it through instead of skipping it is safe and correct. Fixes SeaQL#3172.
Member
|
Slop.
Have you heard of floats? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model_ex macro was silently stripping the Eq derive from the generated ModelEx struct, which triggers clippy::derive_partial_eq_without_eq when -D warnings or clippy::nursery is enabled.
Eq is a trivial marker trait that is always valid when PartialEq is present, so passing it through instead of skipping it is safe and correct.
Fixes #3172.
Assisted-by: poolside/laguna-s-2.1