Repository navigation
chore: sync upstream/main (2025-12-12-2) - #102
Merged
Merged
Conversation
…7893) I am trying to tighten up some of our logic around PowerShell over in openai/codex#7607 and it would be helpful to be more precise about `pwsh.exe` versus `powershell.exe`, as they do not accept the exact same input language. To that end, this PR introduces utilities for detecting each on the system. I think we also want to update `get_user_shell_path()` to return PowerShell instead of `None` on Windows, but we'll consider that in a separate PR since it may require more testing.
…unts (#7915) This PR changes the length validation for SKILL.md `name` and `description` fields so they use character counts rather than byte counts. Aligned character limits to other harnesses. This addresses #7730.
## Notes - Extend reasoning-effort popup warning eligibility to gpt-5.2* models for the Extra High (xhigh) option. ## Revisions - R2: Remove unnecessary tests and snapshots - R1: initial ## Testing - `just fix`, `cargo test -p codex-tui`, and `cargo test -p codex-tui2` - Manual testing **Before**: <img width="864" height="162" alt="image" src="https://github.com/user-attachments/assets/d12a8f11-3ba5-4c31-9ae9-096a408b4971" /> **After** (consistent with GPT 5.1 Codex Max): <img width="864" height="156" alt="image" src="https://github.com/user-attachments/assets/29c0ea7a-c68e-4fac-b10f-15a420ae5953" /> <img width="684" height="154" alt="image" src="https://github.com/user-attachments/assets/b562b8b6-6e63-4dc2-8344-5c7f9a9b6263" />
Prevent TUI to loop for ever if one of the RX it's listing on get closed
Fix race where the PTY was sending first chunk before the subscription to the broadcast
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync fork with upstream/main (through f152b16).
just fmtandcargo test -p codex-tuilocally