Conversation
…sing tests, the dead clause, the pattern cost From Sean MacGuire's review of 0.10.1. A tools/call against a schema the catalog made unenforceable after startup is answered -32603 naming the tool and the keyword (it was a tool result saying "invalid arguments", blaming the client); the new test fails on 0.10.1's server. Tests for additionalProperties as a schema (it kills the review's surviving mutant, the branch replaced by :ok), a list-form type refusing a value of none of its types, and every README keyword accepted well-formed; the `when key in @enforced` clause, which no keyword could reach, and the list it read are removed. The threat model's arguments row says what `pattern` costs (PCRE's match limit, fail closed; 80 ms measured for the worst case a lane tried), inside the row so no threat or status moves. CHANGELOG: the change, and 0.10.1's `nil` reason reading `null`, recorded late. The stdio test helper says why its device is latin1. Gate: sixteen steps pass. Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sean's non-blocking points from the 0.10.1 review, one commit:
tools/callagainst a schema the catalog made unenforceable after startup is now-32603naming the tool and keyword, not an "invalid arguments" tool result (the test fails on 0.10.1's server).additionalPropertiesas a schema (kills the surviving mutant), list-formtyperefusal, every README keyword accepted well-formed.when key in @enforcedclause and its list removed.patterncost (inside the row: no threat or status moves, so the 1.0.0 clock is unaffected).nilreason now readingnull.Left for later, as the review said: compiling the schema once at startup (it touches
ToolSpec, a public struct). Local gate: sixteen steps pass.