feat(s041): complete slice 041 (skill self-management with approval) - #50
Merged
Merged
Conversation
Signed-off-by: Ayla Croft <aylacroft@proton.me>
…h, the scanner, the manager, skill_manage and learn, the pending changes on /skills Every change is staged as the whole target tree under the pending root with a unified diff, the scanner's findings and a skill_changes row; the only apply path is Promotion.swap, which requires an allowed skill_apply approval naming the change's id and digest, archives the previous version under .history, renames the pending tree into place and writes an effect receipt on the skills chain scope; the manager requests and decides the approval through the permission gate (an approval may now have no session: migration and changeset) and applies the persona's auto-approval to none/low only; the census finds the one caller of swap and the two filesystem writers, and the plant; the compaction test's crossing message is sized from the tool surface. Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
…for real line breaks and a run-on answer unflattened; the AC6 sample and AC7 shots Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
…d (lost in the learn edit); the page test covers them Signed-off-by: Ayla Croft <aylacroft@proton.me>
PROOF.md with every criterion's evidence (the learned skill under proof/learned, the three screenshots), NOTES findings and follow-ups, the coverage row (80.55 at ae200d7), and the ROADMAP row to done. Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 041: the agent proposes skills and changes to them (
skill_manage;learndistils a document). Every proposal is staged as the whole target tree under the data directory's pending root with a unified diff, the scanner's findings and askill_changesrow, and never loads. The one path that moves a staged tree into a root isTrinity.Skills.Promotion.swap/4: it requires an allowedskill_applyapproval naming the change's id and digest, archives the previous version under.history/, renames the tree into place and writes an effect receipt on theskillschain scope. The census holds the tree to that one caller and two filesystem writers, with a plant. The persona's auto-approval appliesnoneandlowonly;highnever./skillsgained the pending list, the diff and findings view, approve and reject with a comment, and the learn form.Evidence:
slices/041-skill-self-management/PROOF.md(AC1 to AC8; the learned skill underproof/learned/, three screenshots),NOTES.md(nine findings, four follow-ups).Schema:
approvals.session_idis nullable since this slice (a change approved from the page has no session; the SQLite migration rebuilds the table), andskill_changesis new.Gate on the final tree: run 35637583650, all four legs green; the Postgres leg locally too.
Manual queue for G4: AC6 (
proof/learned/SKILL.md, 32 lines, and its 16-line reference, distilled fromdocs/backup.mdby nvidia:nemotron in 151 s), AC7 (proof/ac7-*.png).Signed-off-by: Ayla Croft aylacroft@proton.me