refactor(test): use captureScreenshot helper from @screenly/edge-apps - #9
Open
nicomiguelino wants to merge 2 commits into
Open
refactor(test): use captureScreenshot helper from @screenly/edge-apps#9nicomiguelino wants to merge 2 commits into
nicomiguelino wants to merge 2 commits into
Conversation
- Replace the manual Playwright context/page/mock/screenshot boilerplate with the new captureScreenshot helper, for both the main and no-api-key resolution loops - Pin @screenly/edge-apps to 26.8.0 Draft: depends on Screenly/edge-apps-library#78 being merged and released as 26.8.0 first.
@screenly/edge-apps 26.8.0 is now published on npm, so bun.lock can resolve it from the registry instead of the local tarball path used while this PR was in draft.
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E screenshot-generation flow for the weather edge app by switching the Playwright screenshot spec to the shared captureScreenshot(browser, options) helper from @screenly/edge-apps/test/screenshots, and pins @screenly/edge-apps to a specific version to ensure the helper’s behavior is stable.
Changes:
- Refactors
e2e/screenshots.spec.tsto callcaptureScreenshotfor both the normal and “no API key” screenshot suites. - Pins
@screenly/edge-appsto26.8.0inpackage.json. - Updates
bun.lockto reflect the dependency bump and resulting transitive updates.
Reviewed changes
Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Pins @screenly/edge-apps to 26.8.0 to lock in the new screenshots helper API/behavior. |
| e2e/screenshots.spec.ts | Replaces custom Playwright context/page/mock/screenshot boilerplate with captureScreenshot(...) usage. |
| bun.lock | Lockfile regeneration after the @screenly/edge-apps version bump (and transitive updates). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/screenshots.spec.tsto use the newcaptureScreenshot(browser, options)helper from@screenly/edge-apps/test/screenshotsinstead of the manually duplicated Playwright context/page/mock/screenshot boilerplate, for both the main andno-api-keyresolution loops.@screenly/edge-appsto26.8.0inpackage.json.screenshots/output for review.