chore: sync development into main - #5
Open
nicomiguelino wants to merge 2 commits into
Open
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56).
nicomiguelino
marked this pull request as ready for review
July 23, 2026 03:37
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🔵 Needs a closer look
The updated lockfile resolves an esbuild version outside Vite’s declared peer range, which can break dev/build tooling and should be corrected before merging.
Pull request overview
This PR syncs changes from development into main, primarily updating the @screenly/edge-apps toolchain to 1.2.1 and aligning deployment workflows/manifests with the newer Edge Apps actions and configuration approach.
Changes:
- Bump
@screenly/edge-appsto^1.2.1(and updatebun.lockaccordingly). - Remove the dedicated
screenly_qc.ymlmanifest and drop theidfield fromscreenly.yml. - Pin Screenly GitHub Actions to a commit SHA and pass
edge_app_idvia secrets/vars in deploy/init workflows.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes embedded manifest id, keeping a single manifest definition. |
screenly_qc.yml |
Deletes the QC-specific manifest file. |
package.json |
Updates @screenly/edge-apps to ^1.2.1. |
bun.lock |
Lockfile updates from the dependency bump (notably Vite/esbuild-related entries). |
.github/workflows/update-edge-app.yml |
Pins update action to a SHA and supplies edge_app_id for stage/prod. |
.github/workflows/initialize-edge-app.yml |
Pins initialize action to a SHA and supplies edge_app_id based on environment. |
Review details
Suppressed comments (1)
package.json:33
@screenly/edge-apps@1.2.1pulls in Vite 8 (see bun.lock:943), which declares a peer requirement ofesbuild^0.27.0 || ^0.28.0. The current lockfile resolvesesbuild@0.17.19(bun.lock:625), which is outside that range and can cause Vite tooling to break at runtime when it imports esbuild.
"devDependencies": {
"@screenly/edge-apps": "^1.2.1",
"@playwright/test": "^1.60.0",
"@types/bun": "^1.3.14",
"@types/jsdom": "^28.0.3",
"bun-types": "^1.3.14",
"jsdom": "^29.1.1",
"npm-run-all2": "^9.0.1",
"prettier": "^3.8.3",
"typescript": "^6.0.3"
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the @screenly/edge-apps 1.2.1 dependency bump (removes the screen name from the app header) from development into main.