ci: use the bun ecosystem for Dependabot, and bump jsdom - #13
Open
vpetersson-bot wants to merge 1 commit into
Open
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
Dependabot was configured with `package-ecosystem: npm` while this repo is
built with bun and commits `bun.lock`. Dependabot therefore rewrote
package.json without touching the lockfile, and every PR it opened died in CI
with:
error: lockfile had changes, but lockfile is frozen
Switch to `package-ecosystem: bun` so the lockfile is updated alongside
package.json, group updates the way the other Edge Apps do, and add the
missing github-actions ecosystem.
Also hold typescript at 6.x: typescript-eslint has no TypeScript 7 support yet
(peer range ">=4.8.4 <6.1.0" as of typescript-eslint 8.70.0), and TypeScript 7
removed the `ts.Extension.Cjs` API that @typescript-eslint/typescript-estree
reads, which makes linting crash.
Finally, land the jsdom and @types/jsdom bumps that #7 and #11 were trying to
make, this time with bun.lock regenerated so the frozen-lockfile check passes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All three open Dependabot PRs in this repo (#7, #8, #11) fail CI with the same error:
The cause is the Dependabot config. This repo builds with bun and commits
bun.lock,but
.github/dependabot.ymldeclarespackage-ecosystem: npm. The npm ecosystem doesnot understand
bun.lock, so Dependabot rewritespackage.jsonalone and leaves thelockfile stale — which the
--frozen-lockfileinstall in CI then rejects. EveryDependabot PR here is dead on arrival.
weather-app is the only Edge App still on the npm ecosystem; every sibling repo
(clock-app, rss-reader-app, bamboo-hr-app, …) uses
package-ecosystem: bunwithgrouping.
Fix
package-ecosystem: bun, sobun.lockis updated alongsidepackage.json.github-actionsecosystem, matching the sibling Edge Apps.typescriptat 6.x.typescript-eslinthas no TypeScript 7 support yet (peerrange
">=4.8.4 <6.1.0"as of 8.70.0), and TypeScript 7 removed thets.Extension.CjsAPI that
@typescript-eslint/typescript-estreereads, so linting crashes. This is thesame hold being applied across the other 20 affected repos.
jsdom29.1.1 → 30.0.1 and@types/jsdom28.0.3 → 30.0.0 bumps that chore(deps-dev): bump jsdom from 29.1.1 to 30.0.1 #7 andchore(deps-dev): bump @types/jsdom from 28.0.3 to 30.0.0 #11 were trying to make, this time with
bun.lockregenerated.Verification
Locally, on this branch:
Follow-up
Once this lands, #7 and #11 are superseded and can be closed. #8 (typescript 6 → 7)
should be closed too — it cannot pass until typescript-eslint supports TypeScript 7,
and the new ignore rule stops it being reopened.
🤖 Generated with Claude Code