chore: sync development into main - #13
Open
nicomiguelino wants to merge 1 commit into
Open
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟢 Approval recommended
Changes are straightforward and align deployment workflows with the intended EDGE_APP_ID rollout, with only a minor maintainability simplification suggested.
Pull request overview
Syncs the EDGE_APP_ID rollout changes from development into main by moving Edge App identification from the manifest files into GitHub Actions workflow inputs, and aligning workflows to a pinned Screenly actions revision.
Changes:
- Removed the hard-coded
idfromscreenly.ymland deleted the separatescreenly_qc.ymlmanifest. - Updated deploy workflows to pin
Screenly/edge-apps-actionsto a specific commit SHA. - Passed
edge_app_idto the Screenlyupdate/initializeactions via secrets/vars fallbacks.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the manifest id so the Edge App ID can be supplied via CI instead of being hard-coded. |
screenly_qc.yml |
Removes the QC manifest file entirely. |
.github/workflows/update-edge-app.yml |
Pins the update action revision and supplies edge_app_id for stage/production updates. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action revision and supplies edge_app_id based on environment/overrides. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| edge_app_name: ${{ inputs.edge_app_name }} | ||
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| environment: ${{ inputs.environment }} | ||
| edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the EDGE_APP_ID rollout changes from
developmentintomain.