feat: adopt Tailwind CSS utility classes for styling - #5
Closed
nicomiguelino wants to merge 1 commit into
Closed
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates this repo to Tailwind CSS utility classes as part of the company-wide rollout across Edge App repos. This is a pure styling refactor — visual appearance and behavior are unchanged.
index.html: replaced custom CSS classes with Tailwind utility classes (arbitrary-value bracket syntax for exact px/rem/color values,portrait:variant for@media (orientation: portrait)overrides). Original class names (header,error-card,channel-card,message, etc.) are kept alongside the new utility classes for stability/readability even though nothing currently depends on them in JS/tests.src/render/index.ts: dynamically created elements (channel cards, message rows, empty state) now get their Tailwind utility classes appended toclassNamealongside the original class name — no change to rendering logic.src/css/style.css: slimmed down to just the Tailwind layer + design-system import boilerplate (no app-specific custom CSS remains, since this app has no@font-faceor other runtime-driven styling).package.json: bumped@screenly/edge-appsto^1.3.0(unpublished; ships Tailwind support). Lockfile untouched — only used a local tarball temporarily to build/test, then reverted.Reference PRs used as the pattern for this migration:
Notes / deviations
developmentbranch existed and was already in sync withmain, so this PR targetsdevelopmentper the standard workflow.text-shadow, sobodyonly neededbg-[#111] text-[#f2f2f3].--color-surface,--card-radius, etc.) were inlined as literal Tailwind arbitrary values, consistent with the reference PRs.m-0on<h2>/<p>in the error card, since the design system's reset only zeroes margin/padding onhtml/body, not on all elements (the app's own removed* { margin: 0 }rule previously handled this).word-break: break-wordbehavior (not Tailwind'sbreak-words, which maps tooverflow-wrap) via the arbitrary property[word-break:break-word]on message/error text.Test plan
bun run type-check— passesbun run build(production) — builds successfully, Tailwind utilities compiled intodist/css/style.cssbun test— 10/10 tests passbun run screenshots— 12/12 Playwright screenshot tests pass; regenerated screenshots reviewed visually (landscape feed, portrait feed, error screen) and match the original design