Pin edge-apps-actions to v26.9.0 tag - #10
Open
nicomiguelino wants to merge 1 commit into
Open
Conversation
Switching from a pinned commit hash to the v26.9.0 version tag is intentional, for easier reference. v26.9.0 points to the exact same commit that was previously pinned by hash, so this is not a reduction in supply-chain safety — it is a readability change, not a move to a floating/unpinned reference.
There was a problem hiding this comment.
🟡 Changes recommended
Using a mutable tag instead of an immutable commit SHA weakens supply-chain guarantees for the action reference.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates GitHub Actions workflow references to use the Screenly/edge-apps-actions@v26.9.0 tag instead of a pinned commit SHA, aiming to improve readability/maintainability of the workflow configuration.
Changes:
- Switched
updateaction references in the update workflow from a commit SHA tov26.9.0. - Switched the
initializeaction reference in the initialize workflow from a commit SHA tov26.9.0.
File summaries
| File | Description |
|---|---|
| .github/workflows/update-edge-app.yml | Updates the Screenly/edge-apps-actions/update ref to v26.9.0 for both stage and production jobs. |
| .github/workflows/initialize-edge-app.yml | Updates the Screenly/edge-apps-actions/initialize ref to v26.9.0. |
Review details
Suppressed comments (1)
.github/workflows/update-edge-app.yml:35
- Pinning a GitHub Action by a mutable tag can weaken supply-chain guarantees (tags can be moved/retargeted). If you want the readability of v26.9.0 while keeping immutability, keep the commit SHA and annotate it with a comment containing the tag.
- uses: Screenly/edge-apps-actions/update@v26.9.0
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenly/edge-apps-actionsreusable actions are switched from the pinned 40-character commit hash (f4ccd2bd50db5fb0a5147d287ac03cafe552d29b) to thev26.9.0release tag.Why
v26.9.0points to the exact same commit that was previously pinned by hash (see https://github.com/Screenly/edge-apps-actions/releases/tag/v26.9.0), so this does not change which code runs.