chore: sync development into main - #46
Open
nicomiguelino wants to merge 1 commit into
Open
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
The new edge_app_id expression in initialize-edge-app.yml can resolve to boolean false and pass "false" as an action input, which is likely to break initialization.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Syncs the EDGE_APP_ID rollout work from development to main by shifting Edge App identification from manifest files into GitHub Actions inputs and aligning workflows to a pinned revision of Screenly’s Edge App actions.
Changes:
- Removed the
idfield fromscreenly.yml, implying Edge App identity is no longer sourced from the manifest. - Deleted
screenly_qc.yml(previously a QC-specific manifest variant). - Updated initialization/update workflows to pin Screenly actions to a specific commit and pass
edge_app_idfrom secrets/vars.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the manifest id, shifting identification away from the manifest. |
screenly_qc.yml |
Deletes the QC manifest file entirely. |
.github/workflows/update-edge-app.yml |
Pins the update action to a commit SHA and supplies edge_app_id via secrets/vars for stage/production jobs. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action to a commit SHA and supplies edge_app_id via secrets/vars based on selected environment. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| edge_app_name: ${{ inputs.edge_app_name }} | ||
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| environment: ${{ inputs.environment }} | ||
| edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the EDGE_APP_ID rollout changes from
developmentintomain.