Use EDGE_APP_ID for stage and production deploys - #45
Merged
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
The edge_app_id expression in the initialize workflow can resolve to a boolean false under misconfiguration, which may pass an invalid value to the action.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Edge App deployment/initialization workflows to use an explicit edge_app_id (preferring an EDGE_APP_ID secret with repo-variable fallbacks), and simplifies the Screenly manifest setup by consolidating to a single manifest file across environments.
Changes:
- Pass
edge_app_idinto theinitializeandupdateGitHub Actions, preferringsecrets.EDGE_APP_IDand falling back tovars.STAGE_EDGE_APP_ID/vars.PRODUCTION_EDGE_APP_ID. - Pin
Screenly/edge-apps-actionsto a specific commit SHA in workflows. - Remove the manifest
idfromscreenly.ymland deletescreenly_qc.ymlto use one manifest across environments.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes manifest id to support using a single manifest independent of environment. |
screenly_qc.yml |
Deletes the QC-specific manifest since a single manifest is now used. |
.github/workflows/update-edge-app.yml |
Pins the update action and supplies edge_app_id for stage/production updates with secret/variable fallback. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action and supplies edge_app_id based on environment with secret/variable fallback. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STAGE_EDGE_APP_IDandPRODUCTION_EDGE_APP_IDrepo variables and pass them through to theinitialize/updateactions asedge_app_id. AnEDGE_APP_IDenvironment secret takes precedence when set, with these variables as the fallback until one exists, so switching to Environment secrets later needs no workflow changes.idfromscreenly.ymland deletedscreenly_qc.ymlsince a single manifest is now used regardless of environment.edge-apps-actionsto a commit for now, sincev26.9.0can't be tagged there until a repo ruleset is adjusted. Will switch to the tag once it exists.