chore: sync development into main - #30
Conversation
- Removes the screen name from the app header (Screenly/edge-apps-library#56) - Regenerates screenshots to reflect the updated header
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
Removing screenly_qc.yml breaks existing stage workflows that still reference that manifest file.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Syncs changes from development into main, primarily updating the @screenly/edge-apps tooling dependency and aligning deployment workflows/manifests with the newer Edge Apps action usage.
Changes:
- Bump
@screenly/edge-appsfrom^1.0.0to^1.2.1(and updatebun.lockaccordingly). - Update GitHub Actions workflows to use a pinned commit SHA for
Screenly/edge-apps-actions/*and passedge_app_idfrom secrets/vars. - Remove the
idfield fromscreenly.ymland deletescreenly_qc.yml.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the manifest id field. |
screenly_qc.yml |
Deletes the stage/QC manifest file. |
package.json |
Bumps @screenly/edge-apps devDependency to ^1.2.1. |
bun.lock |
Lockfile updates from the dependency bump. |
.github/workflows/update-edge-app.yml |
Pins the update action to a commit SHA and provides edge_app_id. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action to a commit SHA and provides edge_app_id selection logic. |
Review details
- Files reviewed: 5/16 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…kflows The multi-app initialize/update-rss-reader-apps workflows target screenly_qc.yml for stage deploys independently of the standard initialize/update-edge-app actions. Deleting it broke that path.
There was a problem hiding this comment.
🔵 Needs a closer look
The dependency bump currently results in a Vite↔esbuild peer version mismatch in the lockfile that can break build/dev scripts unless addressed.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
package.json:14
@screenly/edge-apps@^1.2.1pulls in Vite 8 (see bun.lock:958), which declares a peer dependency onesbuild^0.27.0 || ^0.28.0, but the lock currently resolvesesbuild@0.17.19(bun.lock:630). This version mismatch can breakedge-apps-scripts dev/buildat runtime; add an explicitesbuilddevDependency in the supported range and regeneratebun.lock.
"devDependencies": {
"@playwright/test": "^1.58.0",
"@screenly/edge-apps": "^1.2.1",
"@types/bun": "^1.3.13",
"@types/jsdom": "^28.0.1",
"bun-types": "^1.3.13",
"jsdom": "^29.1.1",
"npm-run-all2": "^8.0.4",
"prettier": "^3.8.3",
"typescript": "^6.0.3"
},
- Files reviewed: 4/15 changed files
- Comments generated: 0 new
- Review effort level: Lite
Syncs the @screenly/edge-apps 1.2.1 dependency bump (removes the screen name from the app header) from development into main.