chore: sync development into main - #5
Open
nicomiguelino wants to merge 2 commits into
Open
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56).
nicomiguelino
marked this pull request as ready for review
July 23, 2026 03:38
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
The dependency bump introduces a Vite/esbuild version mismatch risk (Vite expects esbuild ^0.27/^0.28 but the lockfile only has esbuild 0.17.x), which could break builds at runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Syncs development into main to pick up the @screenly/edge-apps 1.2.1 bump and align deployment workflows with the updated Edge Apps tooling.
Changes:
- Bumped
@screenly/edge-appsto^1.2.1and updatedbun.lockaccordingly. - Simplified manifests by removing the
idfromscreenly.ymland deletingscreenly_qc.yml. - Updated GitHub workflows to pin Screenly actions to a commit SHA and pass
edge_app_idvia secrets/vars.
File summaries
| File | Description |
|---|---|
| screenly.yml | Removes manifest id, leaving a single manifest definition for the app. |
| screenly_qc.yml | Deletes the QC manifest file. |
| package.json | Bumps @screenly/edge-apps dependency to ^1.2.1. |
| bun.lock | Lockfile updates from dependency bump (notably Vite/tooling graph changes). |
| .github/workflows/update-edge-app.yml | Pins update action to a SHA and supplies edge_app_id from secrets/vars. |
| .github/workflows/initialize-edge-app.yml | Pins initialize action to a SHA and supplies edge_app_id from secrets/vars with env-based selection. |
Review details
- Files reviewed: 5/16 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs from development into main: