chore: sync development into main - #8
Open
nicomiguelino wants to merge 2 commits into
Open
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56). This app does not render <app-header>, so there is no visual impact here.
nicomiguelino
marked this pull request as ready for review
July 23, 2026 03:37
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize action and the CLI-based deploy job as EDGE_APP_ID - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
The updated lockfile includes a Vite/esbuild peer-version mismatch that is likely to cause installation warnings and may break builds at runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Syncs development into main to bring in the updated @screenly/edge-apps toolchain and associated deployment/manifest adjustments for the Power BI edge app.
Changes:
- Removes the manifest
idfromscreenly.ymland deletes the stage-specificscreenly_qc.yml. - Updates
bun.lockto reflect the dependency/tooling updates (including@screenly/edge-apps@1.2.1and Vite 8). - Updates GitHub workflows to use a single manifest and to pass an
edge_app_idduring initialization (and pins the initialize action to a commit SHA).
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the manifest id field. |
screenly_qc.yml |
Deletes the QC/stage manifest file. |
bun.lock |
Updates locked dependency graph (notably @screenly/edge-apps, Vite/tooling). |
.github/workflows/update-edge-app.yml |
Uses screenly.yml as the manifest and introduces EDGE_APP_ID env selection logic. |
.github/workflows/initialize-edge-app.yml |
Pins initialize action to a SHA and passes edge_app_id for stage/production selection. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the @screenly/edge-apps 1.2.1 dependency bump (removes the screen name from the app header) from development into main.