Use EDGE_APP_ID for stage and production deploys - #12
Merged
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize action and the CLI-based deploy job as EDGE_APP_ID - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟡 Changes recommended
The new EDGE_APP_ID fallback expression can resolve to boolean false in a realistic misconfiguration case, which would likely break deploy/initialize in a confusing way.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Edge App deployment/initialization workflows to consistently supply EDGE_APP_ID via GitHub Actions secrets/variables (instead of manifest id fields), while consolidating down to a single manifest file.
Changes:
- Pass
EDGE_APP_IDinto both the initialize workflow action and the CLI-based deploy workflow using env/inputs, with repo variables as a fallback to an environment secret. - Consolidate manifests by removing the
idfield fromscreenly.ymland deletingscreenly_qc.yml. - Pin
Screenly/edge-apps-actions/initializeto a specific commit SHA.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes manifest id so the app ID can come from env instead. |
screenly_qc.yml |
Deletes the QC-specific manifest now that one manifest is used across envs. |
.github/workflows/update-edge-app.yml |
Uses a single manifest file and injects EDGE_APP_ID into the deploy job environment. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action and supplies edge_app_id via secrets/vars fallback. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STAGE_EDGE_APP_IDandPRODUCTION_EDGE_APP_IDrepo variables and pass them through asEDGE_APP_IDto theinitializeaction and to the CLI-based deploy job. AnEDGE_APP_IDenvironment secret takes precedence when set, with these variables as the fallback until one exists, so switching to Environment secrets later needs no workflow changes.idfromscreenly.ymland deletedscreenly_qc.ymlsince a single manifest is now used regardless of environment (the CLI now readsEDGE_APP_IDfrom the environment instead of the manifest).edge-apps-actionsto a commit for now, sincev26.9.0can't be tagged there until a repo ruleset is adjusted. Will switch to the tag once it exists.Note: unlike the other Edge App repos, this repo's
update-edge-app.ymldeploys directly viascreenly/cli@masterrather than theedge-apps-actions/updateaction, soEDGE_APP_IDis passed via jobenv:instead of an action input.