Skip to content

Use EDGE_APP_ID for stage and production deploys - #12

Merged
nicomiguelino merged 1 commit into
developmentfrom
feature/edge-app-id-env-var
Sep 4, 2026
Merged

Use EDGE_APP_ID for stage and production deploys#12
nicomiguelino merged 1 commit into
developmentfrom
feature/edge-app-id-env-var

Conversation

@nicomiguelino

Copy link
Copy Markdown
Contributor
  • Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through as EDGE_APP_ID to the initialize action and to the CLI-based deploy job. An EDGE_APP_ID environment secret takes precedence when set, with these variables as the fallback until one exists, so switching to Environment secrets later needs no workflow changes.
  • Dropped id from screenly.yml and deleted screenly_qc.yml since a single manifest is now used regardless of environment (the CLI now reads EDGE_APP_ID from the environment instead of the manifest).
  • Pinned edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted. Will switch to the tag once it exists.

Note: unlike the other Edge App repos, this repo's update-edge-app.yml deploys directly via screenly/cli@master rather than the edge-apps-actions/update action, so EDGE_APP_ID is passed via job env: instead of an action input.

- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize action and the CLI-based deploy job as EDGE_APP_ID
- Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment
- Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Copilot AI lite review requested due to automatic review settings September 4, 2026 00:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new EDGE_APP_ID fallback expression can resolve to boolean false in a realistic misconfiguration case, which would likely break deploy/initialize in a confusing way.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Edge App deployment/initialization workflows to consistently supply EDGE_APP_ID via GitHub Actions secrets/variables (instead of manifest id fields), while consolidating down to a single manifest file.

Changes:

  • Pass EDGE_APP_ID into both the initialize workflow action and the CLI-based deploy workflow using env/inputs, with repo variables as a fallback to an environment secret.
  • Consolidate manifests by removing the id field from screenly.yml and deleting screenly_qc.yml.
  • Pin Screenly/edge-apps-actions/initialize to a specific commit SHA.
File summaries
File Description
screenly.yml Removes manifest id so the app ID can come from env instead.
screenly_qc.yml Deletes the QC-specific manifest now that one manifest is used across envs.
.github/workflows/update-edge-app.yml Uses a single manifest file and injects EDGE_APP_ID into the deploy job environment.
.github/workflows/initialize-edge-app.yml Pins the initialize action and supplies edge_app_id via secrets/vars fallback.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/initialize-edge-app.yml
Comment thread .github/workflows/update-edge-app.yml
@nicomiguelino
nicomiguelino merged commit 2df4c4e into development Sep 4, 2026
2 checks passed
@nicomiguelino
nicomiguelino deleted the feature/edge-app-id-env-var branch September 4, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants