feat: adopt Tailwind CSS utility classes for styling - #6
Open
nicomiguelino wants to merge 2 commits into
Open
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
nicomiguelino
marked this pull request as ready for review
August 4, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind utility classes (with arbitrary-value bracket syntax for exact colors/dimensions) instead of custom CSS classes, keeping visual appearance and behavior unchanged.src/css/style.cssdown to the standard layered import pattern:@import 'tailwindcss'and never pulled in the shared@screenly/edge-apps/stylesdesign-system reset/tokens at all — it now does, via thebaselayer, ensuring Tailwind utilities always win the cascade.)@screenly/edge-appsto^1.3.0(unpublished; ships Tailwind CSS support).screenshots/*to reflect the change.This is part of the company-wide rollout of Tailwind CSS across edge-app repos. Reference implementations:
Notes
<img>showing the rendered Grafana dashboard), so there was minimal custom styling to convert. The only behavioral nuance preserved is thebackground-color: var(--theme-color-background, #ffffff)fallback on<body>, kept asbg-[var(--theme-color-background,#ffffff)], and the original font-stack fallback (no visible effect today, but preserved for parity) as an arbitraryfont-[...]utility..tssources ore2e/screenshots.spec.ts(JS only ever queries#content imgby id), so nothing needed to stay verbatim for functional reasons.bun.lockis intentionally left untouched — only used a local tarball of@screenly/edge-apps@1.3.0temporarily to build/test.Test plan
bun run type-checkpassesbun test src/— 13/13 tests passbun run buildsucceedsbun run screenshots— 12/12 Playwright screenshot tests pass (landscape, portrait, and display-errors variants across all target resolutions)