Skip to content

Use EDGE_APP_ID for stage and production deploys #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicomiguelino merged 4 commits into from
Sep 3, 2026
Merged

Use EDGE_APP_ID for stage and production deploys #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c14518
Use EDGE_APP_ID for stage and production deploys
nicomiguelino Sep 3, 2026
c25caac
fix(ci): avoid cross-environment edge_app_id fallback, drop unused .e…
nicomiguelino Sep 3, 2026
2fb6165
temporary: add marker header to verify deploy pipeline
nicomiguelino Sep 3, 2026
4855e98
Revert "temporary: add marker header to verify deploy pipeline"
nicomiguelino Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/initialize-edge-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ jobs:
- uses: actions/checkout@v7
with:
ref: ${{ inputs.environment == 'production' && 'main' || github.ref }}
- uses: Screenly/edge-apps-actions/initialize@v1
- uses: Screenly/edge-apps-actions/initialize@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b
with:
screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }}
edge_app_name: ${{ inputs.edge_app_name }}
edge_app_title: ${{ inputs.edge_app_title }}
environment: ${{ inputs.environment }}
edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }}
Comment thread
nicomiguelino marked this conversation as resolved.
6 changes: 4 additions & 2 deletions .github/workflows/update-edge-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ jobs:
environment: stage
steps:
- uses: actions/checkout@v7
- uses: Screenly/edge-apps-actions/update@v1
- uses: Screenly/edge-apps-actions/update@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b
with:
screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }}
environment: stage
delete_missing_settings: 'true'
edge_app_id: ${{ secrets.EDGE_APP_ID || vars.STAGE_EDGE_APP_ID }}
Comment thread
nicomiguelino marked this conversation as resolved.

deploy-production:
name: Updating Clock App in production
Expand All @@ -31,8 +32,9 @@ jobs:
environment: production
steps:
- uses: actions/checkout@v7
- uses: Screenly/edge-apps-actions/update@v1
- uses: Screenly/edge-apps-actions/update@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b
with:
screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }}
environment: production
delete_missing_settings: 'true'
edge_app_id: ${{ secrets.EDGE_APP_ID || vars.PRODUCTION_EDGE_APP_ID }}
Comment thread
nicomiguelino marked this conversation as resolved.
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ mock-data.yml
static/js/*.js
static/js/*.js.map
screenshots/*.png
.env
1 change: 0 additions & 1 deletion screenly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
syntax: manifest_v1
id: 01HKT2K8GVE8P6RE36QFKPG5G1
description: Screenly Clock Edge App
icon: https://playground.srly.io/edge-apps/icons/clock.svg
author: Screenly, Inc.
Expand Down
88 changes: 0 additions & 88 deletions screenly_qc.yml
View file
Open in desktop

This file was deleted.