refactor(test): use captureScreenshot helper from @screenly/edge-apps - #15
Open
nicomiguelino wants to merge 2 commits into
Open
refactor(test): use captureScreenshot helper from @screenly/edge-apps#15nicomiguelino wants to merge 2 commits into
nicomiguelino wants to merge 2 commits into
Conversation
- Replace the manual Playwright context/page/mock/screenshot boilerplate with the new captureScreenshot helper - Pin @screenly/edge-apps to 26.8.0 Draft: depends on Screenly/edge-apps-library#78 being merged and released as 26.8.0 first.
@screenly/edge-apps 26.8.0 is now published on npm, so bun.lock can resolve it from the registry instead of the local tarball path used while this PR was in draft.
There was a problem hiding this comment.
Pull request overview
Refactors the Playwright-based screenshot E2E spec to rely on the shared captureScreenshot(browser, options) helper from @screenly/edge-apps/test/screenshots, while updating the @screenly/edge-apps dev dependency (and resulting lockfile) to a newer pinned version.
Changes:
- Refactor
e2e/screenshots.spec.tsto usecaptureScreenshotand asetupMockscallback instead of manual context/page setup and boilerplate mocking. - Pin
@screenly/edge-appsto26.8.0inpackage.json. - Update
bun.lockto reflect the dependency bump and its resolved versions.
Reviewed changes
Copilot reviewed 2 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Pins @screenly/edge-apps to 26.8.0 to consume the new screenshot helper. |
| e2e/screenshots.spec.ts | Switches screenshot generation to the shared captureScreenshot helper and simplifies mocking setup. |
| bun.lock | Refreshes resolved dependency graph after the @screenly/edge-apps version change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+28
| await captureScreenshot(browser, { | ||
| width, | ||
| height, | ||
| filenamePrefix: 'clock-app', | ||
| screenlyJsContent, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/screenshots.spec.tsto use the newcaptureScreenshot(browser, options)helper from@screenly/edge-apps/test/screenshotsinstead of the manually duplicated Playwright context/page/mock/screenshot boilerplate.@screenly/edge-appsto26.8.0inpackage.json.screenshots/output for review.