chore: sync development into main - #11
Open
nicomiguelino wants to merge 6 commits into
Open
Conversation
Removes the screen name from the app header (Screenly/edge-apps-library#56). Regenerates screenshots to reflect the updated header.
nicomiguelino
marked this pull request as ready for review
July 23, 2026 03:37
* feat: redesign the clock as a full page display - Replace the photo background with a wash built from the customer accent - Call setupTheme so brand colours reach the app for the first time - Scale the time to roughly two thirds of the canvas, with tabular numerals - Swap Kelly Slab for Inter, already bundled by the SDK - Remove app-header, leaving auto-scaler as the only component in the markup * feat: switch to a light palette for light brand colours - Use isLightColor from the SDK to test the resolved accent colour - Redefine the canvas, ink and rule tokens under a single body class Requires @screenly/edge-apps v1.5.0, which is not published yet. * feat: add a style setting with modern and minimal options - Add a Style select to both manifests, defaulting to traditional - Fall back to traditional for any value the build does not recognise - Drive the type scale from custom properties so each style is one block - Modern is left aligned and heavier, minimal is lighter with a faint wash * chore(deps): bump @screenly/edge-apps to 1.5.0 - Picks up the released isLightColor helper the app already imports
There was a problem hiding this comment.
Pull request overview
This PR syncs UI/theming changes and a Screenly Edge Apps dependency bump from development into main, updating the clock’s markup/CSS and introducing a configurable “style” setting.
Changes:
- Bump
@screenly/edge-appsand adopt new theme helpers (setupTheme,isLightColor) to drive brand-aware styling. - Redesign the clock layout and styling (new HTML structure + revamped CSS variables for style variants).
- Add a new
stylesetting (manifest + resolver + unit tests) to selecttraditional|modern|minimal.
Reviewed changes
Copilot reviewed 8 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/style.ts | Adds style resolution and reads the style setting with fallback behavior. |
| src/style.test.ts | Adds unit tests for style normalization and fallback behavior. |
| src/main.ts | Applies theme + style classes and updates weather rendering behavior. |
| src/css/style.css | Replaces legacy layout styling with variable-driven clock styles and variants. |
| screenly.yml | Adds the style setting to the production manifest. |
| screenly_qc.yml | Adds the style setting to the QC manifest. |
| package.json | Updates @screenly/edge-apps dependency version. |
| index.html | Updates DOM structure to match the new clock layout (and removes header usage). |
| bun.lock | Lockfile updates reflecting the dependency bump and transitive changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Use querySelector<HTMLImageElement> to satisfy type-checking
- Add explicit esbuild ^0.28.0 devDependency - Regenerate bun.lock so resolution matches vite's esbuild peer range (^0.27.0 || ^0.28.0)
There was a problem hiding this comment.
🟢 Approval recommended
The changes are internally consistent (manifest ↔ runtime ↔ UI), include targeted tests for the new style logic, and no functional regressions were identified in the updated initialization flow.
Review details
- Files reviewed: 10/24 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs development into main, including the @screenly/edge-apps dependency bump to 1.5.0 and the redesigned full-page clock display (removes the screen name from the app header).